Skip to content

Reduce the dependency of pkg/compression on c/storage/pkg/chunked#1312

Merged
rhatdan merged 2 commits intocontainers:mainfrom
mtrmac:compression-deps-harder
Jul 27, 2021
Merged

Reduce the dependency of pkg/compression on c/storage/pkg/chunked#1312
rhatdan merged 2 commits intocontainers:mainfrom
mtrmac:compression-deps-harder

Conversation

@mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jul 23, 2021

WIP, includes #1310 and unmerged containers/storage#972 .

Take advantage of containers/storage#972 so that pkg/compression doesn’t depend on all of c/storage including the graph drivers; this matters for various metadata-only or metadata-mostly users of (parts of) c/image.

Another partial fix to #1146 .

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 23, 2021

Note to self: After this merges, update MCO, per openshift/machine-config-operator#2689 .

@mtrmac mtrmac force-pushed the compression-deps-harder branch 3 times, most recently from 1bd9bd3 to f34479b Compare July 26, 2021 16:01
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 26, 2021

Updated to use released c/storage instead of a fork, still includes unmerged #1310.

Alternatively, I could close #1310 and propose both in this PR.

@rhatdan
Copy link
Member

rhatdan commented Jul 26, 2021

#1310 is merged.

mtrmac added 2 commits July 26, 2021 21:36
... to get github.com/containers/storage/pkg/chunked/compressor .

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac force-pushed the compression-deps-harder branch from f34479b to 13aff82 Compare July 26, 2021 19:36
@mtrmac mtrmac marked this pull request as ready for review July 26, 2021 19:38
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 26, 2021

Rebased, ready for review.

@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons.

@rhatdan
Copy link
Member

rhatdan commented Jul 27, 2021

LGTM

@rhatdan rhatdan merged commit 52ac993 into containers:main Jul 27, 2021
@mtrmac mtrmac deleted the compression-deps-harder branch July 27, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants